https://www.chiliproject.org/2011-02-10T07:57:47+01:00ChiliProjectChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=98692011-02-10T07:57:47+01:00Yuki Sonodayugui@yugui.jp
<ul><li><strong>Start date</strong> set to <i>2011-02-10</i></li><li><strong>Estimated time</strong> deleted ()</li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Normal</i></li><li><strong>Project</strong> set to <i>ChiliProject</i></li><li><strong>Target version</strong> set to <i>1.1.0 — Bell</i></li><li><strong>Assignee</strong> deleted ()</li><li><strong>% Done</strong> changed from <i>0</i> to <i>0</i></li><li><strong>Subject</strong> set to <i>[PATCH] RSS autodiscovery for wiki pages </i></li><li><strong>Category</strong> set to <i>Wikis</i></li><li><strong>Tracker</strong> set to <i>Feature</i></li><li><strong>Due date</strong> deleted ()</li><li><strong>Subproject of</strong> deleted ()</li><li><strong>Description</strong> set to <i>This is a carboy copy of http://www.redmine.org/issues/7574. @timfelgentreff ...</i> <a href="/journals/9869/diff/description" class="lightbox-ajax">More</a></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=9442011-02-10T09:02:50+01:00Felix Schäferfelix+chili@oh14.de
<ul></ul><p>I haven't looked if the patch applies cleanly, but it seems sound in principle. I'll wait to hear any naysayers and will merge it later.</p> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=9652011-02-10T23:51:19+01:00Eric Davis
<ul></ul><p>This should also update the footer on the wiki to give a link to the Atom feed:</p>
<pre>
Also available in: ATOM | HTML | TXT
</pre> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=9732011-02-11T08:35:01+01:00Felix Schäferfelix+chili@oh14.de
<ul></ul><p>I'm preparing the pull request, I need this note to be able to link to it though :-)</p>
<p>I have merged and corrected the patch in a <a href="https://github.com/thegcat/chiliproject/tree/f%2F168-rss_autodiscovery_for_wiki_pages" class="external">branch</a> and corrected additional but mostly unrelated Atom feed links. 2 things though:</p>
<ul>
<li>The links could be misleading as they link to the activity for the whole wiki, not just the page they are shown on. I'm OK with adding them for now and making a note to add atom feeds to single wiki pages later.</li>
<li>Is it OK to keep the fixes to the atom links on the index and date_index page bundled with those, should I commit it separately directly to master, should I open a new bug even though it's only a small fix…?</li>
</ul> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=9742011-02-11T08:36:13+01:00Felix Schäferfelix+chili@oh14.de
<ul></ul><p>(Pull request is here: <a class="external" href="https://github.com/chiliproject/chiliproject/pull/4">https://github.com/chiliproject/chiliproject/pull/4</a>)</p> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=9842011-02-11T18:54:59+01:00Eric Davis
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Ready for review</i></li></ul><p>Felix:</p>
<p>I think you are right:</p>
<ol>
<li>The Title and Date index pages should have header links to the activity of edits for the whole wiki (correct in your pull request)</li>
<li>The Title and Date index pages should have icon links to the activity of edits for the whole wiki (correct in your pull request)</li>
<li>The individual pages should have header and icon links to the activity of edits but only for that page. Almost like a feed of the history action. (incorrect in your pull request)</li>
</ol>
<p>We should open a new feature request for per page RSS feeds since that is different than what Yuki is proposing (related to this issue).</p>
<p>I think your branch is fine. Normally commit <a href="https://www.chiliproject.org/projects/chiliproject/repository/revisions/05e6e910988396413aa5be66b37261dd2d274a79" class="changeset" title="Fis Atom links on wiki index pages.">05e6e910988396413aa5be66b37261dd2d274a79</a> should have been on a separate branch but it's such a minor fix that it doesn't matter. (We should add a test here eventually though, using webrat or something to click the actual links...)</p> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=9932011-02-11T21:38:11+01:00Felix Schäferfelix+chili@oh14.de
<ul></ul><p>Eric Davis wrote:</p>
<blockquote>
<p>We should open a new feature request for per page RSS feeds since that is different than what Yuki is proposing (related to this issue).</p>
</blockquote>
<p>As I said, I'm fine with having the general links for the moment (better than nothing) but that should be improved on later on (new issue). I'll merge it this WE.</p> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=10032011-02-12T14:25:56+01:00Felix Schäferfelix+chili@oh14.de
<ul><li><strong>Status</strong> changed from <i>Ready for review</i> to <i>Closed</i></li></ul><p>Felix Schäfer wrote:</p>
<blockquote>
<p>I'll merge it this WE.</p>
</blockquote>
<p>Done in <a href="https://www.chiliproject.org/projects/chiliproject/repository/revisions/7973847e117d0c653615ff373ccce43cccd655e5" class="changeset" title="Merge branch 'f/168-rss_autodiscovery_for_wiki_pages'">7973847e117d0c653615ff373ccce43cccd655e5</a>.</p> ChiliProject - Feature #168: [PATCH] RSS autodiscovery for wiki pages https://www.chiliproject.org/issues/168?journal_id=12632011-02-27T22:08:23+01:00Eric Davis
<ul><li><strong>Target version</strong> set to <i>1.1.0 — Bell</i></li></ul>