https://www.chiliproject.org/2011-05-09T16:00:14+02:00ChiliProjectChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=100892011-05-09T16:00:14+02:00Florian Mutterelm+chiliproject@skweez.net
<ul><li><strong>Start date</strong> set to <i>2011-05-09</i></li><li><strong>Estimated time</strong> deleted ()</li><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Normal</i></li><li><strong>Project</strong> set to <i>ChiliProject</i></li><li><strong>Target version</strong> deleted ()</li><li><strong>Assignee</strong> set to <i>Eric Davis</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>0</i></li><li><strong>Subject</strong> set to <i>Add LDAP filter to ldap authentication</i></li><li><strong>Category</strong> deleted ()</li><li><strong>Tracker</strong> set to <i>Feature</i></li><li><strong>Due date</strong> deleted ()</li><li><strong>Subproject of</strong> deleted ()</li><li><strong>Description</strong> set to <i>An LDAP filter will provide a simple way to restrict the access to ChiliProje...</i> <a href="/journals/10089/diff/description" class="lightbox-ajax">More</a></li><li><strong>Status</strong> changed from <i>Open</i> to <i>Ready for review</i></li></ul> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=18482011-05-20T15:42:01+02:00Eric Davis
<ul><li><strong>Assignee</strong> set to <i>Eric Davis</i></li></ul><p>Wow, this is almost identical to an LDAP filter I wrote for a client (<a href="https://github.com/edavis10/redmine_branches/blob/bill-las/app/models/auth_source_ldap.rb#L199-208" class="external">part of code</a>). I think we can add it but I might use my version because I think I have some tests for it too. I also didn't have to upgrade Net::LDAP at all.</p>
<p>Do you have a working LDAP installation? I have a bunch of other LDAP code I'd like to get a second opinion on too (failover, basic ldap groups, pulling LDAP attributes into ChiliProject custom fields).</p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=18522011-05-20T15:53:20+02:00Florian Mutterelm+chiliproject@skweez.net
<ul></ul><p>Hey,</p>
<p>yes, I have an working LDAP setup. I can test your changes if you like... but the I have to install ChiliProject first :)</p>
<p>The update of Net::LDAP was not required for this patch but for the things I wrote into the filter. As far as I remember, the filter did not work if it contained a space character.</p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=23262011-07-16T18:24:41+02:00Florian Mutterelm+chiliproject@skweez.net
<ul></ul><p>Hey,</p>
<p>my Chili installation is working now and I would like to test your code if this is still needed... so it can be moved in the core :)</p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=31072011-12-11T15:03:44+01:00Felix Schäferfelix+chili@oh14.de
<ul></ul><p>Hi Florian,</p>
<p>I just had a quick look at your pull request and it looks good so far, though I have some comments, I've added them to the pull request on github. Also, net-ldap has been moved from vendor/plugins to the gemfile.</p>
<p>Could you update your pull request to the current chiliproject master and include the comments from github? Thanks!</p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=31092011-12-11T15:11:10+01:00Holger Justchiliproject@meine-er.de
<ul></ul><p>BTW: The pull request is at <a class="external" href="https://github.com/chiliproject/chiliproject/pull/49">https://github.com/chiliproject/chiliproject/pull/49</a></p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=31232011-12-13T20:17:53+01:00Florian Mutterelm+chiliproject@skweez.net
<ul></ul><p>New pull request is here: <a class="external" href="https://github.com/chiliproject/chiliproject/pull/142">https://github.com/chiliproject/chiliproject/pull/142</a></p>
<p>This is a rewrite of the patch with code from Eric Davis including updated tests. I tested the code and it works fine here.</p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=31302011-12-14T22:15:10+01:00Eric Davis
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Ready for review</i></li></ul><p>Code looks good to me. If another one of the contributers can verify the tests pass then we can include it for 3.0.</p> ChiliProject - Feature #388: Add LDAP filter to ldap authenticationhttps://www.chiliproject.org/issues/388?journal_id=116962011-12-18T19:40:11+01:00Felix Schäferfelix+chili@oh14.de
<ul><li><strong>Target version</strong> set to <i>2.6.0</i></li><li><strong>Status</strong> changed from <i>Ready for review</i> to <i>Closed</i></li></ul><p>The <code>auth_source_ldap_test</code> tests run for me, merged in <a href="https://www.chiliproject.org/projects/chiliproject/repository/revisions/44cf67032f23a58d23e8532f9b45e49474d9a20e" class="changeset" title="Merge pull request #142 from elm/custom-ldap-filter [#388] Custom LDAP filter">44cf670</a>. Florian, thanks a lot!</p>