ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Fix monkey patching of rubytree in lib/redmine/menu_manager.rb (Bug #266)


Added by Gregor Schmidt at 2011-03-07 02:50 pm. Updated at 2011-03-07 09:05 pm.


Status:Closed Start date:2011-03-07
Priority:Normal Due date:
Assignee:Holger Just % Done:

0%

Category:-
Target version:1.2.0
Remote issue URL: Affected version:

Description

In lib/redmine/menu_manager.rb the rubytree gem is patched by Redmine/ChiliProject. During plugin development this regularly leads to Stack-Level-Too-Deep-Errors for me. This is caused by the unconditional aliasing of initialize. Because of this, I am unable to patch any functionality inside this source file, which includes the MenuManager and MenuHelper.

I propose to fix the unfortunate style of patching.

Note: I just want to fix my current itch. I guess, patching the rubytree gem itself might already cause some controversy, but this should IMHO not be discussed in this ticket. All I want to achieve is, that the given monkey patch becomes more robust.


History

Updated by Gregor Schmidt at 2011-03-07 02:57 pm

I'm working on a pull request.

Updated by Gregor Schmidt at 2011-03-07 03:35 pm

  • Status changed from Open to Ready for review

Updated by Gregor Schmidt at 2011-03-07 03:35 pm

  • Assignee deleted (Gregor Schmidt)

Updated by Holger Just at 2011-03-07 09:05 pm

  • Assignee set to Holger Just
  • Status changed from Ready for review to Closed

Also available in: Atom PDF