ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

« Previous - Version 6/18 (diff) - Next » - Current version
Eric Davis, 2011-07-12 12:13 am


Edavis10

This is Eric's personal page to keep track of things.

Legend

  • A - Accept
  • R - Reject, with reason
  • H - Help or feedback needed from others
  • F - Accept with a fix
  • P - Pending

Code reviews pending

From ChiliProject launch to latest Redmine trunk at 2011-02-03.

  • A - 483133285e96ad5701d0ce11d76a106d8c5e49cd Add responders to UsersController.
  • AH - "Uses bundler for XML/JSON api with a lot of method_missing. This might need to be reviewed, esp performance" - 96ce0f017cfe58210d84e5092446395b811ccdab Adds a builder-like template system for rendering xml and json API responses.
  • AH - "Hardcoded fields in the API - e9775097ec5da895cece3085915865faa4a51710 Adds xml/json REST API for Users (#6260).
  • A - ea59d93dc82d9675586c4b2e176fb4b7640e3158 Dry Users API responders.
  • A - d0a3aab2e70241f9ce03704c2c87ed7cb2f2e4b6 Adds a reusable method to render API response on validation failure.
  • AH - "Hardcoded fields in the API. Using bundler format" - a1f12e3adeeffa55e66f0727f1b5994465e73429 Converts ProjectsController to use the new API template system.
  • A - eaf6bb1e9bc1ac3b5309f51ea9f76e6f95ba5813 Projects API tests rewriting.
  • AH - "Hardcoded fields in the API. Using bundler format. Changes to the issue JSON API responses, using an 'issues' top level hash" - 735a83c596156e32f8cc686207eecddc029d7629 Converts IssuesController to use the new API template system and makes xml/json responses consistent (#6136).
  • A - f6c633212a4ee6a1d598b4c4c5c0027cfeb9d010 Prevents random failure in XmlTest.
  • A - 9284a32c9ac7b932feb72cf0d2d5fb1626ec7862 Moves project attributes default assignments from ProjectsController#new to the model (#6064).
  • AH - "Hardcoded fields in the API. Using bundler format. Refactor needed in controller#index. Missing #show.html action - f7cf8aa87845f9abf86d3d8e0449409a0d8d2cce Adds REST API for TimeEntries (#6823).
  • A - 37ed02553aee58d1b269c3ec8786bc8daff05484 Fixes test failure in r4461.
  • A - 558a951ed64a3639ac08fdc7245dffab8607ab3f Fixes unhandled case in json builder.
  • A - 88e593ee027b1fc1bdfa63b6ab76b0ae51ec6295 Fixes unhandled case in json builder.
  • AH - "Rendering nested subtasks in the show API doesn't feel right, especially since the HTML doesn't even display them all. Should it just render a list of ids for fetching later instead?" - 915748204965bb7f9704b55554e30f091934138e Adds subtasks to GET /issues/:id API (#5338).
  • AH - "Overrides a core Rails method for finding templates. Potential Rails compatibility issue" - 224921460a0a3d9c97813e4a64f0903adffff22f Adds a pseudo format to api template names and overrides ActionController#default_template so that api templates are chosen automatically.
  • A - 7fb0fe2e910a4188db283c359d9b1d05dad99041 Safer code in IssueRelation (#7018).
  • A - 8841ba97c680fb826b228e8de8a586e61bc428bf Fixed: class attribute with spaces on pre tags truncated (#7033).
  • A - 80e0e1c5448a15568bb9a2205b0566eb19fa3b8a Changes russian CSV separator to ; (#7035).
  • A - d7c607fd8b1efe8467509220025bbdbbfe076b47 Automatic spent time logging from commit messages (#4155).
  • A - bfa61c1ec49a7429d0eb667dc6a58b76660e2ec5 Updated locales.
  • A - b0a1a0400825de2c4c84d7a428e0427b600fa099 Gantt: iterate over all objects only once for html and pdf rendering (#6348).
  • A - b17e145d75f926d435fdac81af0d9629d75149a0 Gantt: view cleanup.
  • A - 9c6377964c43ed034cf644a22311810629f42934 Fixes gantt PDF pagination problem (#6348).
  • A - 318bd10c7f4dcbbb3dff472380929f70be53c863 Gantt: fixes position of line in pdf (#6348).
  • A - 4715a37937cb30192df17a7db18c5f31f24463b0 Gantt: Avoid unnecessary queries before rendering.
  • AF - "Needs tests for Project#due_date without issue tracking or versions." - b8982008036624581c1eaa8f92adaa383fafd04e Select projects with issue_tracking module for gantt display and remove the nil start/due dates trick.
  • A - 8524d505c5c092ead4f6be1fedfc38311b3c7b91 Add tests for wiki edit notifications (#7024).
  • AH - "More API builder. Adds even more objects into the issue's API response." - 0e19aa4362a0524d900044fc9dc69e177337eca0 Fixed: error when serializing back objects with custom fields using ActiveResource (#6403).
  • AF - "Missing tests for acts_as_customizable changes" - 3e3315c103f232655ac8553fcd476792f7d24691 Support for updating custom fields using the received custom_fields array (#6345, #6403).
  • A - 252e4983fba7e11103d1da29650a62f54dd46433 Fixes a fixture with valid attributes (start_date < due_date).
  • A - ab6a93b029b236f94a0c33cc0282f0af22b646b5 Changes the representation of journal details in issue API.
  • A - cd71c1cc0ad732af55e9665cfc742c066647536f Do not try to copy relations for issues that could not be copied.
  • A - 10ba08ce13f2cfd088fb8eba0d8dd1be6145acc1 Fixes unsafe assertion that may cause failures.
  • AF - "This fixes some performance concerns I had with the new API in regards to lots of objects getting created" - 5f57bceabbdccb9e13dd2f0a0a52a0e7fa704c6e Makes some attributes optional in API response to get faster/lightweight responses.
  • A - f2b42237d09e7b23dead7b7a4b724102e3eb224c Fixes indentation.
  • A - 67f1131a2051b03c8214ce82dcc2051e0e9871a2 Fixes duplicate custom_values fixture that caused failure with Postgresql.
  • AH - "Requires API client modification for pagination. I think this should default to off to work with ActiveResource and then allow clients to turn it on if they want it. Or provide our own ActiveResource wrapper that supports pagination." - 00d50157d3d6ee8a12cf41d74c0a4e0da7fc9c35 Restores object count and adds offset/limit attributes to API responses for paginated collections (#6140).
  • A - 8407db985475efb8e5892b8fa325be01e125ff3f Fixes Changeset#text_tag for numeric scmid (#6681).
  • AH - "safe_attributes is difficult to use and inflexible. We should use the built in attr_* methods in Rails instead of a custom version" - 3409333522a76ade39db41124df596b2b95eccc0 Makes issue safe_attributes extensible (#6000).
  • AH - "See above about safe_attributes" - a4d7a99c22d9aac89a38c1cb411158777b72bb9d Declare safe attributes for User and Projects models.
  • A - cde02954c84591c66c575f0d76d44c18ab6edf95 Moves password param to user hash param so that it can be set using the User API.
  • AF - "Using symbols instead of strings is better because there is only one version of each symbol" - e4f319fe6122d466ac57fc18761d8ac78c981e60 Validates user's mail_notification and turn options into strings (the attribute type).
  • A - 1d4f28a54dec696e34f1477f440471c97d521963 Removed no longer needed to_sym.
  • A - 9e2d401f43d9136e887cb099a72ecc33d9dd88f5 Moves mail_notification param to user hash param so that it can be set using the User API.
  • A - 2066b2f6665156670c7dcbff944cc3c5a827075d Code cleanup.
  • A - 87ae744dce313076211ff472eb95edb65a048c82 Fixes test according to r4493.
  • A - 0a2ec6ef0472fc0a14fe5793408c0546ebf39e4d Extracts user groups assignment from controller.
  • A - a49c7f95e236422d560e09a1ecc0555279ab0bbe Fixes password sending when creating user.
  • AF - "Removes shared shoulda with old style test naming" - 758f2f0a4efdab9b8e4654efb71fbbdd81fa7b00 UsersController tests cleanup.
  • A - a8b12bcb520230b9cc25abd2d7346d746c49874d Autocomplete issue relations on subject (#3170).
  • A - 29e0bca43a6df01fe14b92ac2214eaf02b06ee62 Make sure there's no nil result in auto_complete.
  • A - aaee26ae229f1f6cc863094aa58f32c434c98c58 Use GET instead of POST to retrieve context menu (#6762).
  • AH - "Builder API. Removed to_xml/to_json in favor of hard coded templates" - ac60fc9c1c587ba1f600c7d17723d2b88f2b6bed Refactor and add tests for News #index API (#7072).
  • A - a8cf13e8c8fb60d001ce44defda4988305f8d865 Restores the issue description label (#6677).
  • A - e120f2aab4b1e8471c6bcfeb8984022ee5a254e1 Fixes tests after fixtures changes.
  • A - f9f1bd58d6a6563e99b067195975c7b101817ab0 Fixed bad html generated in users/memberships partial (multiple </tbody> tags)
  • A - 17f86d964fe05e677714baa35ec319abe13ae8bf Use absolute paths in test/**/* requires for Ruby 1.9.2 compatibility. #4050
  • A - 9ac043a09681bf93ff57155ff38a4400d3391fb0 Set encoding to utf-8 for ruby 1.9 compatibility. #4050
  • A - 335f8da5e81e1974baa13e18be579a8007788dfd Fixed: 404 when entering time with blank issue id (#7099).
  • A - 6a586c39e9f018d8bf787d5b78a54fa61e478cc6 Adds journal created_on attribute to issue API (#7111).
  • AH - "I think the default value should be nil, that way the entire Gantt is shown which is the historic behavior" - b48291ec63b58224df7b250ba62445dcbf5c835e Adds an application setting to limit the number of items that can be displayed on the gantt chart (#6276).
  • A - 252dcad3f618bbadb8be6e5fd0c87e5f0c50c008 Locales update.
  • A - 9f18426ca7b1e798ffd763382721660c674d2043 Skip a few SQL queries for cross project gantt.
  • AH - "Hardcodes the i18n gem requirement. Should check to see if there is a range of them first, and if not then maybe bundle it with the app until upgrading" - 3c1576e364c911e38f7c002582fc794f16ca87dd Manually require i18n 0.4.2 before Rails tries to load the most recent gem (#7013).
  • A - 4f4a62c6d07d318067a6e765c2d757f43a669d13 Locales update before changing interpolation format.
  • AH - "Potentially breaks i18n compatibility with plugins. Might be a good time to force them to change though, with the port to ChiliProject..." - bc1703d7b6c3d00a5a66412fa0ab8694c337ede7 Converts translations to the new i18n interpolation format (#6495).
  • A - 1c3823cbb015293889cd025c647709e78f3387b1 Adds missing strings in locales.
  • A - 27f76d20ce702c607b3e527efb8d11bc2451de78 Gantt: fixes progress width in some cases and start code cleaning.
  • AF - "Uses a css class of task, should standarize names (issue vs task). Uses a css class of label which will be confusing with the HTML element called label" - 8f7da03419071e132bbda1c1983707de15350597 Gantt code cleanup.
  • AF - "Need to rename the milestone*.png images to be version*.png" - 98c7c179ca3fb614ba4544f1199eaaaae56c6524 Gantt code cleanup.
  • A - edc35d4d5b04395765f730af44fa80b37b3ead20 Gantt code cleanup.
  • A - 88a802b25edd6ab1531dbe86daa9108110c10d5f Gantt: make the pdf looks more like html.
  • A - 74a94ed4adf6cbdde1ea6e6f49cef993a9596405 Gantt: make the png looks more like html.
  • A - 084e9e2e5731c9d8b4bdc591e23098fcff3016f8 Gantt code cleanup.
  • A - 8a86b2d2bc8b5bd954739d23b24adb850b94e074 Gantt code cleaning.
  • A - 620c1e27894801b853c1714acc51025b12d2e724 Adds a css class for gantt subjects.
  • A - df88dc117ff9676e1a4b38944d2388c029203353 Fixed: r4492 breaks the ability to select issue custom fields available for projects issues (#7121).
  • A - 0c24f88ce1c72a0b551bb8dfd84bc35725545db6 Fixed: issue description Quote button lost by r3941 (#7122).
  • A - 86e17ce74ffd400b9aa03efb3e92f61507df1b2e Sort versions drop down on the bulk edit form.
  • A - 525656a4900f01fb1032e7ca92a3deac16386c5b Ported subtasks display with indentation to the new gantt (#7128) and fixed markers alignment.
  • A - 93847ae33740232e7e6e7a6a4a2dba45ea421932 Fixes a data disclosure issue introduced in r3941.
  • A - a7595ec19154427bf38812208ac8443c2dca5462 Adds tests for class attribute parsing on pre/code tags.
  • A - 7d7c67dabad1ad7d50bade26a0f6316e13868ea6 Fixed that some arguments where not properly escaped in scm adapters.
  • A - f7529c94f651fef7d42c4cb609890de5a2ec9ea5 Fixes mercurial adapter.
  • A - 84dd413f22b9a3900ceaa33d63758f285908ecb1 Restore rev param validation that was removed in r2840.
  • A - 599bc450730b91769f878d38b76110ce5c8fbca7 Adds support for requesting information about current user using /users/current (#7141).
  • A - 6d4126f17ecfb053f8050fea67496983a0353383 Adds routing tests for users and xml format.
  • A - 339bcc97e0e199091d1d9f4c88272d6acecefc43 Adds tasks to run scm tests: test:scm:units, test:scm:functionals and test:scm.
  • A - 4695754d2a773ac00f675dc24c5f1cc89a7095d6 Fixes task description.
  • A - c42b0ad6b75e7a480b37c56f853d50be78e3fc2d Adds missing fixtures when running tests from scratch.
  • A - 03397f605c7ece40b38ebdcf49bd5e4fe9040ac8 Fixes valid revision regexp.
  • A - 8a8ca4036490dfb16c437b43123a5ed90585da44 Prevents n SQL queries (n = project count) on cross-project issues list.
  • A - ef288fbff7dd472f48bd45768a0d43f65f02e3f8 Broken links on wiki diff view.
  • A - 3d76a67a2e108ea64618670d4ece5de0c2253436 Force vertical scroll bar to avoid layout jump.
  • A - 703b0ec422bbb9bac775254e8e284a4b145551e2 Fixed: 500 error on issue query grouped by a custom field that was deleted (#7144).
  • A - 0661cf6d871abacd6d05062e2ec2c6a7a6c96301 Restores non english field_start_date translations (#6629, #7016).
  • A - 72f58c4c407b35ce02d4ca16178698068ef8cfa5 Adds missing not_a_date translation in fr locale (#7160).
  • AH - "While this is good, I think it would be better to use existing theme libraries or plugins instead of custom code" - 523febf9c1b31991fed52fe5878bec3153f8aafb Support for Javascript in Themes (#2803).
  • A - c8dc7fff08b9cb0848bfe43ceac2c4f5dbdce0fe Avoid theme rescan when no theme is selected.
  • A - 3b53ec20e672bee080b49b67c0e2598ce57063ee Adds themes test for when Redmine is in a sub-uri.
  • A - 759048e73a9bef1569be51f1f0f1caf3b7a3e504 Fixes: Mercurial adapter loses seconds of commit times (#6656).
  • A - 3ef41c31318d3b8ec938de6daaf38d47218624eb Updated CHANGELOG for 1.0.5
  • A - d78a51064235dfd50b7cfab1eefda1f095611393 Updated INSTALL for 1.0.5
  • A - 1ee7f31f4d84891542bb37e2f7e36b16a9d66c70 Set VERSION to 1.0.5.
  • P - d076c1982227af8af1c7505db131367ee6e40b99 Makes API accept offset/limit or page/limit parameters for retrieving collections.
  • P - 283d25d82334c00f2cf70770f50ae5649e6d791f Makes /projects API accept same pagination parameters as other API collection resources.
  • P - 07fe46e9dfc1567d24de4ff8799a1e1c048b2adc Makes the API accepts the X-Redmine-API-Key header to hold the API key.
  • P - df9ea24136059b502d156cb69c8bb2b9b6d952e1 Makes Version#start_date return the minimum start_date of its issues.
  • P - 21c0b868ae1d7836dcfe34ac0ad740df981e304d Fixed: Tracker reset to default when replying to an issue email (#7197).
  • P - 03d4ecbbff99492cf96695a87d39ce20c0692a4f Fixed: CLI-supplied defaults should not be applied when replying to an issue (#7195).
  • P - 0025a6620087824486f7508a8c6f56351a676cc1 Fixed: cvs diff broken by r4539 (#7176).
  • P - af7006dff6f8ee4e74a3ec793fe0457f2d5a41e7 Fixed: partial toc when text contains pre tags (#7172).
  • P - e9a0e6dbc8bff4afbd299d23431944fbab453e17 Takes more parameters into account to determine activity freshness (#7188).
  • P - d2cc2861de766d1c0f1e38f9d1b48c16e46b2e1c Find visible issues only in ContextMenusController#issues.
  • P - f2ae2e923946ee9d27e7232cafcd0505dfb52118 Simple issue sort method to make sure subtasks appear under their parent on the gantt (#7128).
  • P - ad620607539c661b40a07146df3ced78c13a16e3 Disable project completion display on the gantt (#7127).
  • P - 82f528ddc8c843583c0313a000ae1fa6e5bc1345 Makes issue move form similar to bulk edit form.
  • P - dd87ebef58642c629d6ff44db550bc361b08ff01 Makes the png looks more like the html gantt.
  • P - 5e725070e02de903cfe189104ff6e4b97b24ab25 German translation updated (#7161).
  • P - 74de89d1ddf471b4ef88f314e3468d71aaafb064 Traditional Chinese language updated (#7123).
  • P - 4d557dd512a0002c017b7256636d7a8c2626fde5 Japanese Translation updated (#7133).
  • P - 6659c630b264325c6fc22c0ba353d724fd1a1817 Fixes wrong Polish translation of "blocks" and "duplicates" (#6895).
  • P - 3eebd827d7b2cd6e259dd8fd7386553b35005e5a ruby1.9 compatibility
  • P - 92d34234b01f7d0e7850b50ccd2559f1e63cac5d Safer assertion.
  • P - 44ffc5a3365ffd16d6971d1c3f691a2f3f80ba3b Remove the limitation on characters that can be used in custom_field, issue_status, role, tracker, user names (#5152).
  • P - d3a926df6411785d32fde4ef0344d028ad16cfd3 Fixes wrong assertion.
  • P - 9748567452ccaf89e566622e2cf851da5dafc78d ruby1.9 compatibility
  • P - 2c830770cb39d962e12b072fdebffc35c457888b ruby1.9 compatibility
  • P - 1c7079db3fb099c6913353c9d56c27628b712026 Read attachment fixtures in binary mode.
  • P - 488285e12321fc590dee0235470cfb12d77a3432 Strip non utf8 content when displaying diff (ruby1.9 compatibility).
  • P - ad727d378100bba88ee16df38f534f1d6fd495db Fixes utf8 conversions with ruby1.9.
  • P - 1294fe2c9636d4b0bbe41f7f7829dd9a1fb0396f Adding .hgignore based on the .gitignore.
  • P - 35c35a193cd705134cf20fdf1950a8155c33d0f8 repository: switch darcs cat test if cat supports.
  • P - d29052f682cc1583888fe13095d0af0e2fc81a0f Added missing remove_index in AddUniqueIndexOnMembers down migration. #7212
  • P - 2ae2d3ef834c4d17b1c7a4e09f299b537f91d3cc Fixed: repository: mercurial: sort changesets by revision (#3449, #3567).
  • P - 2e1bcb2abff6f78f028064299125480cbf3c2c2a Changing revision label and identifier at SCM adapter level (#3724, #6092)
  • P - ce8113dea2a73eff5286bfbc31a2042693943471 Additional roles of a user who belongs to a group are not always copied when copying the project (#7213).
  • P - 2d9b9362a9cf35a32f7959725c307a36b0ab9a97 Fixed: should redirect to the new project when copying a project.
  • P - a4c5787b537f1a7b16cade58b5c53de782db1b32 Updated footer to 2011.
  • P - e0d6f8db1d83183517f139561bc09e2fcf2488e1 Set version to 1.1.0.
  • P - 29fddddaf1b2ee3e0c8c6759d1e0c0a9cc13475c Fixed failing subversion test.
  • P - 8487e0a5b83ff63bd02a8e4a061a587c8a37ce78 Fix subversion and git activities test reffering r4621.
  • P - 7958facadcc30fcce2f9ba27602944e713ce85f6 repository: git: change io.gets to io.readlines (#5404, #5096).
  • P - 5e1c42cbe3b0d3b5d6825870b3d99c18bc6060ef repository: mercurial: fix functional annotate test.
  • P - e86b8febdc79626d441d958e56856ae22b7604ae scm: mercurial: refactor mercurial unit test.
  • P - 0f8680adfd5ec0486505fb1491cc38a1f45a4a8a scm: mercurial: fix comment and change // to '' some strings of functional test.
  • P - 6ad68ae0277c9e2a1d09d46f7b2db8dc8e1310df scm: mercurial: cleanup indent and trailing white-space of unit lib test.
  • P - ad18cfda32debd5e183baf167af386d797365ffa scm: mercurial: escape any filenames by urlescape (#2664, #7064).
  • P - 9ee02d04f370e9be1e29ebfd03b703d913900fe5 scm: mercurial: update test repository for following issues and fix tests.
  • P - f4c5fe43cb0307573e09e973ec9510720380f986 scm: mercurial: add some tests at unit and functional test.
  • P - 1bf33bb619591b72ca1765345ce673902e3ae2e3 scm: mercurial: add unit test for copied file (#7064).
  • P - e6118347d37a8773dfcdda3b77225f33c422febb Adds a rake task test:scm:update to update test repositories if needed.
  • P - 7620142b7015860e11afb696f67877f03323a8a0 Adds assertion to prevent error in test.
  • P - 9fb770ba503b3dfe1fe48794e1b7042c5e26d8d7 Moves enabled_module_names param to project attribute so that it can be set through the Project API.
  • P - 072c4ad14cf0649545ceab6261558a32c234e720 Verify HTTP method on ProjectsController#create.
  • P - 9222cf91eab448a2f5177f4ce6b40924f0df252c Changes ProjectsController#modules param name and add tests.
  • P - 88d65c514927094e348010d31fa17fcd2a60bd69 Do not show trackers and issue custom fields on project form when issue tracking is disabled (#7225).
  • P - 306a47023ce13d5c18d11470bf1ba7df0b1317e8 Additional unit tests for project tree.
  • P - e7a9c386efc92d84e9c371bd976ec5d395705e23 Removed hard-coded style on wiki history view.
  • P - 3ad213c29ab8be303fe7514c613919b44bffc5a9 Fix associated revisions label on issue page.
  • P - e2df831b537c6a038a799e236cc497a59d3a79e7 scm: mercurial: accept both of revision and nodeid as changeset id (#3724).
  • P - 7484096cdcaf936e4e29c45b5a8b64c3c60bc69a scm: mercurial: fix assert_equal parameter order at app unit test_find_changeset_by_name().
  • P - d0a076cbfddbd60c94374621706ee364e5dbc3aa Bulgarian translation update by Ivan Cenov (#7203).
  • P - 0617625f487c5d3fcaf363e22896a8e9902b4169 Italian translation update by Emidio Stani (#7227).
  • P - 0743ba89d405fba39b94fa58a0dc4f799b604e49 scm: mercurial: cat test for accept both of revision number and changeset id (#3724).
  • P - 5207211b6d02dd36a8aa3e691d125a03137cdf2e scm: mercurial: fix diff and test for accept both of revision number and changeset id (#3724).
  • P - ef28bf6d88f66e2a61bb14169671cc8fbb8086e0 scm: mercurial: annotate accepts both of revision number and changeset id (#3724).
  • P - a223a0dffdcae1ca6474b79775f3967a28cb9d5b scm: mercurial: functional test for accept both of revision number and changeset id (#3724).
  • P - e4f72a8e3afb6027954e594f4866a222630a6860 scm: add compatible functional test fof changing diff revisions label at SCM adapter level.
  • P - ed246cef41b14fd3e8c15e6fafcef284c9ae9dd7 scm: mercurial: wrap identifier with shell_quote at hgrev(identifier).
  • P - 08c093bc8507035078dbb370f261cf1e10afefbf scm: mercurial: replace identifier to hgrev(identifier).
  • P - 1ff52e5c5a58cd9cfe6f5c73f0af293673a095bf scm: mercurial: add --git option in 'hg diff' (#7253).
  • P - b017a846ba7354555da6de892651fe9723b7ffb6 scm: mercurial: remove new line in diff unit test(#7253).
  • P - 18cb215d72f7de92c6cfb23a99ee1dbf73b5b9c2 Updated CHANGELOG for 1.1.0 release.
  • P - 50d962bba14d8ab2cefa6ae64df8e568a04755fe Trying to fix random failures with postgresql due to different ids order in urls.
  • P - a9eea27742ddf4b7ba8930d292ec2564417a72d1 Fixes random failure (database may not return changes in the order expected in the test).
  • P - 2cbf60851fe95e57264c1abfb778bde1f05fa6e7 Store the mercurial test repository as a bundle to make it compatible with older hg versions.
  • P - bebde1596cf51be7064f9d4a569f54b0cdc1c7cf Make sure en is the current locale when running the test (#7266).
  • P - 88727bf070ed11b73c75a2510143c15c685254a0 Adds fallback to 'en' locale for untranslated strings (#5518).
  • P - f1a5dca2ba84c814da024ebd5b5564a6fbecdccb Fixed: wiki pages with cyrillic characters not found with postgresql (#7245).
  • P - a9c4ec31ca844e1796f40925c879aed8b500552c Fixes fixture added in r4680.
  • P - 7b7577c747ce9bf7b8289aa4f7c1884ceb74767f Fixed MailHandler broken by I18n fallback added in r4679.
  • P - 35b9972c8199bb273007388db3b9cb71b7febe0b scm: mercurial: test:scm:setup:mercurial task can be simpler (#7272).
  • P - a6f05b5e56fdc9523340c2a7bb8c0ca77317045f scm: mercurial: diff '-c' option supports above Mercurial 1.2 (#3724, #7253).
  • P - 331cdbed2fe690fcaa20064fb8a71514198347cc scm: mercurial: fix r4686 setup mercurial test repository (#7272).
  • P - 80b329d031dc29791f850e979d58cba872e1154b scm: mercurial: change diff option from --git to --config diff.git=false (#7253).
  • P - 6a6b68d29515cea7c83a8651cfc9b5d7490a6f4c scm: add compatible "commit:xxx" link test for git and darcs.
  • P - e92cd2091cbb251f0cc27e2aabb7058db40c7f00 scm: fix assert_equal parameter order in subversion and git unit test.
  • P - fb51f27b8a1533abaf7d84bf86e33cec0d18a8ec scm: fix indents in "commit:xxx" unit test.
  • P - 36b99a4ed39bf80cf87e0693cba21506cdee45e4 scm: use scmid for "commit:xxx" link if available (#3724).
  • P - d67185ec7e1aad57954633b70d71fc4c6a0ba58e scm: mercurial: use scmid as identifier (#3724).
  • P - f17e1ce368c9a90bf30012c7dae5f69891cc1438 scm: mercurial: add "commit:xxx" and "rNN" link test for mercurial (#3724).
  • P - fdd0a2ca9b72687d6a22849c62c2868def1b8322 scm: mercurial: use revision text mercurial style "2:400bb8672109" (#3724).
  • P - ebb19c58637cfd9af4264d28e9aaa924a68f294e scm: changing two revision diff text at SCM adapter level (#3724).
  • P - eda1cd2faa39584d648a697d94186059ff4a886b scm: mercurial: change two revision diff text of mercurial (#3724).
  • P - 2f3b1ca6b8855eea3850036e6c60c8464b806a25 Fixed: Enabling gravatas causes usernames to overlap first name field in user list (#7277).
  • P - c19e3fbe3a49bc90c2ce29bfb63bad469a805a13 Set csv separator to ; for nl locale (#7274).
  • P - 43f6a626808a41ea3c7a82947a0db0b3fbcb7ebd Removed obsolete css class (#7279).
  • P - 98b3a5065756995ff5768c9f354790549fd81509 scm: fix error on revision page for empty revision (#7307).
  • P - 89627d0334e567d1e52d7797badb169991e47992 scm: mercurial: fix error on revision page for empty revision (#7307).
  • P - 7a35682cd9aca946ad37efc5e902d47f60536929 scm: mercurial: unit lib test for entries accept both of revision number and changeset id (#3724, #3421)
  • P - 88d847a1d51249236a57a2a5ddf2019e448b42c2 Fixes TimeEntry#spent_on= so that datetimes don't get stored in SQLite3 (#7258).
  • P - a81953ef84639e37934ed4fc8a72b4466daeda1a Adds a test for TimeEntry#spent_on= with invalid string.
  • P - 7d0b1b383009dddb535e288f8cbf38b1aa8fb2aa Respond with 404 instead of 500 when revision/entry is not found in the repository (#7307).
  • P - e14e244f7b5e9b205d462de4f46745a02bc3c8c9 Use #blank? instead of #nil? || #empty?.
  • P - acb0d96617390d90f909e4413c80c418dad0ffc9 scm: use #blank? instead of #nil? || #empty? at Repository#find_changeset_by_name(name) (#7307).
  • P - 61a517179d49062b566ea98918ef5b70e0cb4ae3 scm: git: fix id at functional test_empty_revision test(#7307).
  • P - effc33fe5b4f655c587fe70b3caea3abbeef78f7 scm: mercurial: fix id at functional test_empty_revision test(#7307).
  • P - 2b24b6c9bb40df75a34bd31258f49eca4ef5d448 scm: mercurial: fix revision at functional diff test.
  • P - 4c46fa4ef487d0087f90a95d42dda340b80d805e Fixed: "Loading..." icon does not disappear after adding a project member when there is no other member to add (#7265).
  • P - b2425dbe7f8046c7e268ace1225e47e42ee9eeb4 French locale update (#7337).
  • P - d2b6a6bc2cd4577038c7e8ad267c5aee3550ecb5 Adds a test for issue circular dependency validation.
  • P - 7ef527a65354c07e20c921812ec2b7c175925bcc Adds colon after label.
  • P - befd725b8b2441787b2e48369afa54dfbb0223ed Prevent SystemStackError on Issue#all_dependent_issues with circular dependency (#7320).
  • P - 46f2f9cff71838a32470f3f79d64f997b804226c Fixed: Label not translated in french in Settings/Email Notification tab (#7313).
  • P - ced782ecb21c629e13306010ca34bbaa8e3bb473 Adds a User-Agent header to Redmine mailhandler requests (#7318).
  • P - e809d40f4ed988ecd98ecbc162553a5b180b3083 When destroying a user, remove all references to that user (#7296).
  • P - 0e3017dc62c672a291cda6053aaba6bda39b2de4 Fixed: "Notifiy for only project I select" is randomly displayed (#7294).
  • P - e9f62d1209bfa81df33bcb390eb67ba4cab90c0a Enable ability for administrators to delete users (#7296).
  • P - e17fadd07ac34f96a10a8b1e77b9ee06bc4149b2 Do not show "for only project I select" notification option on application settings form (#7294).
  • P - fd3c85dc0d84677632875a68d996a3aafbac0974 Load csshover.htc for IE6 only as later versions support hover on non-link elements.
  • P - 6e1fa1603b16da3e9792e26b3bca5d1618ca24dc scm: use format_revision() for history, view and annotate (#3724).
  • P - ccdea234ad655fab8125e34c0bbad7d27accc886 scm: functional test of using format_revision() for annotate (#3724).
  • P - 419b195019a276513d1d58a0ed7d7a18c58425be Fixed: subtasks are deleted (not destroyed) when destroying parent issue (#7385).
  • P - 494cd8cc363802d6fc15eaeb34fdefe88f15e940 Avoid "private method `gsub' called for nil:NilClass" error when exporting issues with nil description (#7386).
  • P - b9385dceb9c60c2660e05dca972eac22c9030b9b Make POP3 mail fetcher log messages instead of puts (#7177).
  • P - e4faf3553a1b9d22ee171e08f62f112637b05e19 Fixes french translation of "Connection" (#7348).
  • P - 144ca23442a5e123935dea4073670d4dba4caa89 Coderay upgraded to 0.9.7 (#5344).
  • P - 07a49b94ad6debf5257ec5246b50393989ea4697 Removed extraneous hidden_field on wiki history (#7379).
  • P - b8dee485ca0474639edbe7173c45cda850e07459 Moves relations fetching from views to the controller and skip invalid relations (#7385).
  • P - 8fb9728b457e82819769e3df8ee2826f40396886 scm: darcs: add unit lib test.
  • P - 0d3703c0b3b3cc57a59a82252b096d4849c7f2e9 scm: darcs: change io.gets to io.read and add darcs version unit (#4494, #5404).
  • P - 1df08afefddbfe601d7046ed8c82b6c5f8a8bb50 scm: darcs: switch '.' or @url at entries() in darcs version (#4899).
  • P - abd2762aede80ad9fd5cb984d66690bd74804567 scm: darcs: add compatible test of Darcs 2.3 and 2.4 (#7415).
  • P - e173f7e72dff82dfe55656a0ea0b7cf25f0c45de scm: darcs: fix Darcs adapter recognizes new files as modified files above Darcs 2.4 (#7415).
  • P - 4cefae0aaadfadae71d695b17468fca2dfe74541 Adds an application configuration file: config/configuration.yml (#7408).
  • P - 5d32ce6e91543d9246787d3666b86c6a8998033c Ignores db/*.sqlite3.
  • P - 3b28a0e231c5d1895e7b7297840eda68f75d70d5 Ignores eclipse settings files.
  • P - 7dd464c577bd1b41d80554390b4b8a2ff9372e8b Makes the folder for attachments storage configurable in config/configuration.yml (#1236).
  • P - 55acbcb560cc7c635420060bc22bdb2c221a3b8d Makes the autologin cookie configurable (#1763).
  • P - 507f9d753f56c0530bd7411c4de1bc3835c03321 Set the httponly flag on the autologin cookie.
  • P - 777ccf1328c9ebfac33f23e965eccfb5578f182f Adds support for cross project Redmine links (#7409).
  • P - b20210e83c42807e6445b827504afe64323e272d Adds visible scope to redmine links queries.
  • P - a2a01e6b72d81ad9b2c50bccc8f9d4d13d1c5a8a Moves link_to_message to ApplicationHelper to make it available to redmine links.
  • P - 73a2d926f6e43d360421eff3e207b42bd5172184 Fixed: no email sent with 'Notifiy for any event on the selected projects only' (#7421).
  • P - 898a8c885b78af75e0ca14f6cd53c5357d039744 Fixed: Relations are not displayed after adding/removing an issue relation (#7463).
  • P - d39e12c202fcee615f217e50f92f28ebeb6527ce Prevent error when Mantis version.date_order is nil (#7476).
  • P - 0b53c7c22459c3394daea480642e7e2de5a2366d Moves .htaccess to htaccess.fcgi.example (#7256).
  • P - ab2933a4143cd13de17bdf075177d446274b7a33 Translations updates.
  • P - 3c8df553ae3137d0623623d00dcbb77df1b60021 Removed issue subjects wrapping in gantt (#7280).
  • P - 48d3ab5f4449aeaef4d3e332b8af1700eebc4dc6 Reverted r4780 that broke gantt tests (#7280).
  • P - a5e3ac2864a9a7726507ba97b3f6b4779d7a27c6 Update for 1.1.1 release.
  • P - 17595c4e31b1d138f4e5e31fdcdaa9f8f507f344 Ignore config/configuration.yml (#7408).
  • P - f922fa765fb293bcf306797c1d173e8b9c6e576b scm: cvs: change project id of unit app test from 1 to 3.
  • P - 2b79e05e6c528fd2e4959a9547b003695e264c21 scm: cvs: change project id of functional test from 1 to 3.
  • P - f7f858f05663e45b16ff75fe77bd17988a7c40b4 scm: cvs: code clean up.
  • P - 08f02c5b65b6a684fa137e1d4f2972c9d41494f4 scm: cvs: add fetch_changesets at all unit app test methods.
  • P - 9f1a63075e8958f1b1b6aa92bf34e817e0e8a80c scm: mercurial: add unit lib test for the previous changeset isn't the parent (#7253, #7518).
  • P - 33d6b906166a635aabee0a6c14f995061d474c44 scm: cvs: add unit lib test.
  • P - 10ca61a13bd0c168ce0adb0e0aa6724a24187c5c scm: cvs: use localtime at cvs rlog -d option (#996, #3761).
  • P - 0ffe328c0ac35b7593d1300a1a9d7474a5e1af10 scm: add a feature of configurable path of executable for scm adapters (#7517).
  • P - c1ec8c5ea33f9b79bc230d5e3bd2d18c66071a7a scm: use "e.g." for "for example" at config/configuration.yml.example (#7517).
  • P - 3ee203ef0c2b9cc53bc00e1dd6d6e5dcf123de35 scm: change key name of configurable command name (#7517, #6159, #7047).
  • P - fcdeb1613a0483338a6d214aea26774f96b887ce scm: add scm_cvs_command at config/configuration.yml.example (#7517).

Code reviews in progress

  • should be more

Code reviews done

  • can't remember