ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
Attachment deleted issue notification does not include list of changes. (Bug #1174)
| Status: | Needs more information | Start date: | 2012-11-01 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: |  Felix Schäfer |
% Done: | 0% |
| Category: | Issue tracking | ||
| Target version: | - | ||
| Remote issue URL: | Affected version: |
Description
To reproduce: create an issue, add an attachment, delete the attachment. The email notification sent upon delete will not mention that a file was deleted, only that the project was updated.
History
Updated by Greg Thornton at 2012-11-01 08:29 pm
Pull request: https://github.com/chiliproject/chiliproject/pull/233
In Issue::attachment_removed, the new journal is first created without any attributes, then updated with the attributes indicating an attachment was removed. The email notification is triggered upon creation, before the update, meaning the email has no changes to report. This simple patch uses the @extra_journal_attributes attribute provided by acts_as_journalized to pre-fill the journal changes before creation. I suspect that's the intended use of this attribute, although I'm pretty unfamiliar with the internals of acts_as_journalized.
- Status changed from Open to Ready for review
Updated by Felix Schäfer at 2012-11-22 10:19 am
I'll have a look, thanks.
- Assignee set to Felix Schäfer
Updated by Felix Schäfer at 2012-11-22 05:25 pm
See the comment in the pull request :-)
- Status changed from Ready for review to Needs more information
Updated by Greg Thornton at 2013-01-20 12:55 pm
Now that I've gotten way deeper into aaj, I'll take another look at my code and see if there's not a better fix.