ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Help controller headings rendered differently in Ruby 1.9 (Bug #379)


Added by Gregor Schmidt at 2011-05-05 08:53 am. Updated at 2011-05-05 06:46 pm.


Status:Closed Start date:2011-05-05
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:-
Target version:1.4.0
Remote issue URL: Affected version:master

Description

The newly introduced help views to render wiki syntax help dynamically (see #362) use html_title in an unexpected way. This leads to different behavior in Ruby 1.8 and 1.9 since to_s for Arrays changed. This is already covered by functional tests.

<"Wiki Formatting"> expected but was
<"[\"Wiki Formatting\"]">.
<false> is not true. (Test::Unit::AssertionFailedError)
test/functional/help_controller_test.rb:13:in `block in <class:HelpControllerTest>'   

See ci.cp.o for details.


Associated revisions

Revision edb263cd
Added by Gregor Schmidt at 2011-05-05 10:54 am

[#379] using html_title properly

Revision 5938048e
Added by Felix Schäfer at 2011-05-05 08:44 pm

Merge pull request #48 from schmidt/b/379-wrong-header-in-wiki-help

Fix html_title usage in help views for Ruby 1.9. #379

History

Updated by Gregor Schmidt at 2011-05-05 08:56 am

  • Assignee deleted (Gregor Schmidt)
  • Status changed from Open to Ready for review

Updated by Felix Schäfer at 2011-05-05 06:46 pm

Merged in 5938048 (and I'm still wondering who had that idea, but I don't think that's how it was intended to be used…). Thanks.

  • Status changed from Ready for review to Closed

Also available in: Atom PDF