ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Test errors on 1.9.2 after acts_as_journalized merge (Bug #412)


Added by Gregor Schmidt at 2011-05-13 09:51 pm. Updated at 2011-05-13 11:37 pm.


Status:Closed Start date:2011-05-13
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:-
Target version:2.0.0
Remote issue URL: Affected version:unstable

Description

After the acts_as_journalized, the test do no longer run on Ruby 1.9.2. This is the case on my local machine as well as ci.chiliproject.org.

On the one hand, the errors result from an API change in 1.9. Module#instance_methods now returns an Array of Symbols instead of String like in 1.8.7. In vendor/plugins/acts_as_journalized/lib/redmine/acts/journalized/deprecated.rb it is assumed, that the instance_methods returns strings, which is wrong.

Furthermore, there seems to be change in the way require works. This was already an issue with 17f86d96 and somehow also applies to vendor/plugins/acts_as_journalized/lib/acts_as_journalized.rb


Associated revisions

Revision 09fd7123
Added by Gregor Schmidt at 2011-05-13 11:52 pm

[#412] fixes to make tests run on 1.9.2

Revision 00ca2af1
Added by Felix Schäfer at 2011-05-14 01:36 am

Merge pull request #53 from schmidt/b/412-test-errors-in-1.9.2

Fix test errors on 1.9.2 after acts_as_journalized merge. #412

History

Updated by Gregor Schmidt at 2011-05-13 09:55 pm

Pull request is at https://github.com/chiliproject/chiliproject/pull/53.

Thanks for having a look.

  • Assignee deleted (Gregor Schmidt)
  • Status changed from Open to Ready for review

Updated by Felix Schäfer at 2011-05-13 11:37 pm

  • Status changed from Ready for review to Closed

Also available in: Atom PDF