ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Clean up trailing whitespace and tabs (Feature #436)


Added by Eric Davis at 2011-05-29 06:56 pm. Updated at 2011-05-31 08:02 am.


Status:Closed Start date:2011-05-29
Priority:Normal Due date:
Assignee:Holger Just % Done:

0%

Category:Refactoring
Target version:2.0.0
Remote issue URL: Affected version:

Description

In order to update our existing code to the Code Standards we need to remove all trailing whitespace and tabs. I found these rake tasks we might be able to use but I haven't tested them yet.

https://github.com/diaspora/diaspora/blob/c937f76433d96cf6b92649fd546a58dcdd085ee4/lib/tasks/whitespace.rake


Associated revisions

Revision b72785b2
Added by Holger Just at 2011-05-30 08:49 pm

[#436] Adapt rake task to also clean trailing whitespace

Revision 07185fb1
Added by Holger Just at 2011-05-30 08:52 pm

[#436] Remove trailing whitespace

Revision db3480bd
Added by Holger Just at 2011-05-31 09:59 am

[#436] Fix test relying on trailing whitespace.

History

Updated by Holger Just at 2011-05-30 07:29 pm

  • Target version set to 2.0.0
  • Assignee set to Holger Just

Updated by Holger Just at 2011-05-30 07:29 pm

  • Status changed from Open to Closed

Updated by Toshi MARUYAMA at 2011-05-31 02:33 am

You should not remove white-spaces from literal.
test/unit/repository_test.rb#test_for_changeset_comments_strip

https://github.com/chiliproject/chiliproject/blob/99507a03/test/unit/repository_test.rb#L110

  • Status changed from Closed to Open

Updated by Holger Just at 2011-05-31 08:02 am

Toshi MARUYAMA wrote:

You should not remove white-spaces from literal.

I can't really do that without having to actually parse / run the ruby code. And that would be a bit too much a PITA. I'd rather adapt the test to the stated rules. I changed it to not rely in literal trailing whitespace anymore in db3480bdb693e7172c22491592767cadff85c393

  • Status changed from Open to Closed

Also available in: Atom PDF