ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Merge Redmine.pm git smart-http functionality (Feature #245)


Added by Felix Schäfer at 2011-03-01 09:48 am. Updated at 2011-03-22 07:44 am.


Status:Closed Start date:2011-03-01
Priority:Normal Due date:
Assignee:Felix Schäfer % Done:

0%

Category:-
Target version:1.2.0
Remote issue URL: Affected version:

Description

Merge and document the changes from https://orga.fachschaften.org/projects/redmine-fsenorg/repository/revisions/fsenorg/changes/extra/svn/Redmine.pm (they enable git smart-http with Redmine.pm).


Related issues

blocks Task #246: Document git-smart-http integration Closed 2011-03-01

Associated revisions

Revision 9fe45cfe
Added by Felix Schäfer at 2011-03-20 06:45 pm

Add git-smart-http support to apache perl module #245

Latest patch from http://www.redmine.org/issues/4905 and other changes improvements, compare also with https://orga.fachschaften.org/projects/redmine-fsenorg/repository/revisions/fsenorg/changes/extra/svn/Redmine.pm .

History

Updated by Felix Schäfer at 2011-03-01 09:49 am

Holger, IIRC you reviewed the changes for a finn installation, can you confirm it here for the record? Thanks.

Updated by Holger Just at 2011-03-01 09:52 am

We currently run an older version of your patch. It works mostly fine. The latest version of your patch was merged into our codebase but is not deployed yet. But from me looking at it, it's fine :)

Updated by Felix Schäfer at 2011-03-01 09:53 am

And while we're at it, can/shall we rename it ChiliProject.pm? That would require everyone using it to change apache configs and such though, so maybe only for 2.0?

Updated by Holger Just at 2011-03-01 10:00 am

We can/should. But we also should provide a compatibility layer, e.g. a file called Redmine.pm which is just loading ChiliProject.pm (or whatever convention there is for perl modules...). This could then be removed for 2.0 where we should remove most of the painful compatibility layers (or move them into an optional plugin, see #247).

Updated by Felix Schäfer at 2011-03-01 10:04 am

Holger Just wrote:

We can/should. But we also should provide a compatibility layer, e.g. a file called Redmine.pm which is just loading ChiliProject.pm (or whatever convention there is for perl modules…).

Well, the problem is that the package declaration (source:/extra/svn/Redmine.pm#L1) will have to be changed too (the name of the file has no incidence at all on the whole apache module thing IIRC), and I don't know if/how to rename/import/wrap/alias a package in another.

Is there a perl-ot on board? (yeah, bad pun day…)

Updated by Felix Schäfer at 2011-03-20 06:06 pm

Merged in 9fe45cfe1f49d9c2e9ba1949c87d6e6889e3a48d, we'll have to see about renaming the module at a later time.

  • Status changed from Open to Closed

Updated by Eric Davis at 2011-03-21 11:23 pm

Is this safe for a bug-fix release though (1.2.0)? Redmine.pm has no tests for it and tends to be difficult to debug.

Updated by Felix Schäfer at 2011-03-22 07:44 am

It doesn't change the current behavior, the git functionality is added and must be enabled to be active. The only real change to the svn functionality is the addition of the port to the ldaps address.

Anyway, I'm confident it's safe.

Also available in: Atom PDF