ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
Replace checks for "auth_source_id" with "change_password_allowed?" in UsersController (Feature #271)
| Status: | Closed | Start date: | 2011-03-10 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: |  Eric Davis |
% Done: | 0% |
| Category: | User accounts | ||
| Target version: | 1.2.0 | ||
| Remote issue URL: | Affected version: |
Description
In the UsersController actions changing a user's password and submitting a newly set password via mail is done only when there is no AuthSource associated to the user. The "change_password_allowed?" check in the User model is more appropriate for these kinds of checks and allows custom AuthSources that actually want to set a user's password.
History
Updated by Stephan Eckardt at 2011-03-10 01:04 pm
Here is the pull request: https://github.com/chiliproject/chiliproject/pull/21
Updated by Eric Davis at 2011-03-10 11:51 pm
Thanks, I'll review this for you. I wrote the User#check_password? and must have missed UsersController.
- Assignee set to Eric Davis
Updated by Felix Schäfer at 2011-03-19 07:55 pm
That seems like something that could go into 1.2.0? ;-)
Updated by Eric Davis at 2011-03-22 11:33 pm
- Target version set to 1.2.0
Updated by Eric Davis at 2011-03-24 09:24 pm
Merged to master. Thank you for the patch.
- Status changed from Ready for review to Closed