ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
Remove returning since it causes deprecation warnings (Bug #414)
Description
The aaj-merge introduced a returning call.
Kernel#returning will be removed from Rails. Instead Object#tap should be used.
History
Updated by Gregor Schmidt at 2011-05-13 10:28 pm
Pull request is at https://github.com/chiliproject/chiliproject/pull/56.
Thanks for having a look.
- Assignee deleted (
Gregor Schmidt) - Status changed from Open to Ready for review
Updated by Felix Schäfer at 2011-05-13 11:31 pm
From what I was able to gather, Object#tap will probably not work on 1.8.6, one way around that could be to monkey-patch if needed:
1class Object
2 def tap
3 yield self
4 self
5 end
6end
I'd rather not add it per default though.
I'll merge this pull request, if anyone uses ChiliProject 2.0 or newer with 1.8.6, we can still decide how to best handle it.
Updated by Felix Schäfer at 2011-05-13 11:33 pm
Merged in d8ae680abbd00e156c49af9b3dc93c9a8380398d, thanks.
- Status changed from Ready for review to Closed
Updated by Gregor Schmidt at 2011-05-14 06:19 am
This is done in Rails' core already. See https://github.com/rails/rails/blob/2-3-stable/activesupport/lib/active_support/core_ext/object/misc.rb#L56
Updated by Felix Schäfer at 2011-05-14 08:41 am
Gregor Schmidt wrote:
This is done in Rails' core already.
Oh, no more reservations from me then.