Allow underscores in project identifiers (Feature #146)

Added patch file (thanks thegcat)

Oh, forgot, we still need a test for that. So I withdraw my vote until we have a test failing without the patch and passing with it.

Eric Davis wrote:

Holger: should we set the Status to Open? Needs more information is used if the request isn't clear.

Probably better, yes.

Holger Just wrote:

Oh, forgot, we still need a test for that. So I withdraw my vote until we have a test failing without the patch and passing with it.

I'll give it a try. Is this small enough for 1.2.0?

Proposed patch:

 1diff --git a/app/models/project.rb b/app/models/project.rb
 2index 8315a48..eb0da23 100644
 3--- a/app/models/project.rb
 4+++ b/app/models/project.rb
 5@@ -75,7 +75,7 @@ class Project < ActiveRecord::Base
 6   validates_length_of :homepage, :maximum => 255
 7   validates_length_of :identifier, :in => 1..IDENTIFIER_MAX_LENGTH
 8   # donwcase letters, digits, dashes but not digits only
 9-  validates_format_of :identifier, :with => /^(?!\d+$)[a-z0-9\-]*$/, :if => Proc.new { |p| p.identifier_changed? }
10+  validates_format_of :identifier, :with => /^(?!\d+$)[a-z0-9\-_]*$/, :if => Proc.new { |p| p.identifier_changed? }
11   # reserved words
12   validates_exclusion_of :identifier, :in => %w( new )
13
14diff --git a/test/unit/project_test.rb b/test/unit/project_test.rb
15index 8eb79fd..936008b 100644
16--- a/test/unit/project_test.rb
17+++ b/test/unit/project_test.rb
18@@ -101,6 +101,7 @@ class ProjectTest < ActiveSupport::TestCase
19     to_test = {"abc" => true,
20                "ab12" => true,
21                "ab-12" => true,
22+               "ab_12" => true,
23                "12" => false,
24                "new" => false}
25                

As this doesn't break backwards compatibility, I'd even put it in 1.1, feel free to reschedule if you don't agree.

I didn't want to spam with the locale changes :-) Committed in 9ed2d8ed77906c21f6df8331008aad2adcf23148.