ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

[PATCH] RSS autodiscovery for wiki pages (Feature #168)


Added by Yuki Sonoda at 2011-02-10 07:57 am. Updated at 2011-02-27 10:08 pm.


Status:Closed Start date:2011-02-10
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:Wikis
Target version:1.1.0 — Bell
Remote issue URL:http://www.redmine.org/issues/7574 Affected version:

Description

This is a carboy copy of http://www.redmine.org/issues/7574. @timfelgentreff asked me to cc.

Many wiki systems provide a link element for RSS autodiscovery in each wiki page. It is useful for those who want to track changes in wiki pages.

Redmine has an ability to provide such a RSS, however, Redmine's wiki pages don't have such link elements. The attached patch adds the link element in each wiki page. I have used this patch for redmine.ruby-lang.org and I hope you to merge the patch.


rss-autodiscovery-for-wiki-pages.patch (715 Bytes) Yuki Sonoda, 2011-02-10 07:57 am


Associated revisions

Revision e19c7ac2
Added by Felix Schäfer at 2011-02-11 09:01 am

Add an RSS autodiscovery tag to wiki pages. #168

Contributed by Yuki Sonoda.

Revision 9726157e
Added by Felix Schäfer at 2011-02-11 09:21 am

Fix Atom links on the wiki show page. #168

This fixes the autodiscovery link provided in the precedent commit and adds the link to the "other formats" section.

History

Updated by Felix Schäfer at 2011-02-10 09:02 am

I haven't looked if the patch applies cleanly, but it seems sound in principle. I'll wait to hear any naysayers and will merge it later.

Updated by Eric Davis at 2011-02-10 11:51 pm

This should also update the footer on the wiki to give a link to the Atom feed:

Also available in: ATOM | HTML | TXT

Updated by Felix Schäfer at 2011-02-11 08:35 am

I'm preparing the pull request, I need this note to be able to link to it though :-)

I have merged and corrected the patch in a branch and corrected additional but mostly unrelated Atom feed links. 2 things though:

  • The links could be misleading as they link to the activity for the whole wiki, not just the page they are shown on. I'm OK with adding them for now and making a note to add atom feeds to single wiki pages later.
  • Is it OK to keep the fixes to the atom links on the index and date_index page bundled with those, should I commit it separately directly to master, should I open a new bug even though it's only a small fix…?

Updated by Eric Davis at 2011-02-11 06:54 pm

Felix:

I think you are right:

  1. The Title and Date index pages should have header links to the activity of edits for the whole wiki (correct in your pull request)
  2. The Title and Date index pages should have icon links to the activity of edits for the whole wiki (correct in your pull request)
  3. The individual pages should have header and icon links to the activity of edits but only for that page. Almost like a feed of the history action. (incorrect in your pull request)

We should open a new feature request for per page RSS feeds since that is different than what Yuki is proposing (related to this issue).

I think your branch is fine. Normally commit 05e6e910988396413aa5be66b37261dd2d274a79 should have been on a separate branch but it's such a minor fix that it doesn't matter. (We should add a test here eventually though, using webrat or something to click the actual links...)

  • Status changed from Open to Ready for review

Updated by Felix Schäfer at 2011-02-11 09:38 pm

Eric Davis wrote:

We should open a new feature request for per page RSS feeds since that is different than what Yuki is proposing (related to this issue).

As I said, I'm fine with having the general links for the moment (better than nothing) but that should be improved on later on (new issue). I'll merge it this WE.

Updated by Felix Schäfer at 2011-02-12 02:25 pm

Felix Schäfer wrote:

I'll merge it this WE.

Done in 7973847e117d0c653615ff373ccce43cccd655e5.

  • Status changed from Ready for review to Closed

Updated by Eric Davis at 2011-02-27 10:08 pm

  • Target version set to 1.1.0 — Bell

Also available in: Atom PDF