ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

/issues/changes?format=atom is returning 500 Internal Error (Bug #267)

Added by Robert Chady at 2011-03-07 06:23 pm. Updated at 2011-03-19 12:14 am.

Status:Closed Start date:2011-03-07
Priority:Normal Due date:
Assignee:Felix Schäfer % Done:

0%
Category:Issue tracking
Target version:1.2.0
Remote issue URL: Affected version:

Description

The RSS feed for /issues/changes?format=atom stopped working a couple weeks ago now. It used to work, but after some changes on the site it started to return a 500 internal Error.

Associated revisions

Revision c8e584e8
Added by Felix Schäfer at 2011-03-07 07:44 pm

Add the custom_fields helper to JournalsController #267

History

#1
Updated by Felix Schäfer at 2011-03-07 06:31 pm

The interesting part of the log:

ActionView::TemplateError (undefined method `format_value' for #<ActionView::Base:0xd5be200>) on line #23 of app/views/journals/index.rxml:
20:       xml.content "type" => "html" do
21:         xml.text! '<ul>'
22:         change.details.each do |detail|
23:           xml.text! '<li>' + show_detail(detail, false) + '</li>'
24:         end
25:         xml.text! '</ul>'
26:         xml.text! textilizable(change, :notes, :only_path => false) unless change.notes.blank?

I guess some helper is missing, I'll have a look real quick.

  • Target version set to 1.2.0
  • Assignee set to Felix Schäfer

#2
Updated by Felix Schäfer at 2011-03-07 06:46 pm

Felix Schäfer wrote:

I guess some helper is missing.

Bingo, the journals controller is missing the helper :custom_fields. I've committed the change in c8e584e894955779924a3328b844e3a44923e44f.

  • Assignee deleted (Felix Schäfer)
  • Status changed from Open to Ready for review

#3
Updated by Holger Just at 2011-03-07 06:49 pm

I discussed this with Yuki yesterday. The bug occurs because the journals_controller doesn't include the CustomFieldHelper, which is required because of source:app/helpers/issues_helper.rb#L143. The solution would be to either include the helper in the journls controller, or to include the helper into the issues helper. I would prefer the latter.

In the future, this isn't even necessary, as the journals controller is killed by #123.

#4
Updated by Eric Davis at 2011-03-07 07:00 pm

I proposed we add all helper to ApplicationController so these bugs never happen again.

Discussion: https://www.chiliproject.org/boards/2/topics/121

#5
Updated by Eric Davis at 2011-03-19 12:14 am

Felix merged this into master already.

  • Assignee set to Felix Schäfer
  • Category changed from chiliproject.org Website to Issue tracking
  • Status changed from Ready for review to Closed

Also available in: Atom PDF