ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Check for missing Journal code from the AAJ merge (Bug #406)

Added by Eric Davis at 2011-05-13 06:04 pm. Updated at 2011-05-20 10:46 pm.

Status:Closed Start date:2011-05-13
Priority:Normal Due date:
Assignee:Eric Davis % Done:

0%
Category:Journals / History
Target version:2.0.0
Remote issue URL: Affected version:unstable

Description

  • Check JournalsController missing code that wasn't merged
  • Check Journal model for missing code that wasn't merged
  • Check Journals views for missing code that wasn't merged

Related issues

related to Feature #123: Review and Merge acts_as_journalized Closed 2011-02-02

Associated revisions

Revision 8994a0b5
Added by Eric Davis at 2011-05-21 12:37 am

[#406] Added missing and removed unused code for Journals

acts_as_journalized changed the interfaces and didn't include all of
the recent changes to the Journals system.

  • removed Journal diffs, acts_as_journalized handles them differently
  • fixed the Journal atom feed
  • added the journal preview back in
  • added missing tests

History

#2
Updated by Eric Davis at 2011-05-20 09:38 pm

git diff dabe5caa1ab4e4c5cc3ece50ff968d8b0c4be9a4^..dabe5caa1ab4e4c5cc3ece50ff968d8b0c4be9a app/controllers/journals_controller.rb is showing a lot of other missing code. I suspect some view changes are missing too.

#3
Updated by Eric Davis at 2011-05-20 09:48 pm

Model and helper look ok.

#4
Updated by Eric Davis at 2011-05-20 10:46 pm

Did a review and merge of the missing code. Main changes:

  • removed Journal diffs, acts_as_journalized handles them differently
  • fixed the Journal atom feed
  • added the journal preview back in
  • missing tests
  • Status changed from Open to Closed

Also available in: Atom PDF