ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Add Journal#visible (Bug #407)


Added by Eric Davis at 2011-05-13 06:05 pm. Updated at 2011-05-29 06:27 pm.


Status:Closed Start date:2011-05-13
Priority:Normal Due date:
Assignee:Eric Davis % Done:

0%

Category:Journals / History
Target version:2.0.0
Remote issue URL: Affected version:unstable

Description

From Felix

I've also removed the "visible" scope on journals added in 27177def because I haven't found it to be used anywhere, should probably be re-added for compatibility's sake.


Related issues

related to Feature #123: Review and Merge acts_as_journalized Closed 2011-02-02

Associated revisions

Revision aa2b0a87
Added by Eric Davis at 2011-05-13 08:26 pm

[#123 #407] Deferred Journal#visible tests

Revision bc249871
Added by Eric Davis at 2011-05-29 08:11 pm

[#407] Remove deferred Journal#visible tests

History

Updated by Eric Davis at 2011-05-27 05:58 pm

I'm not sure what the best approach for this is. We can't check the view_issues permission because Journals are no longer only issues (WikiContentJournal). We could add an null named scope that returns nothing on Journal and then on each subclass we can add the proper permissions. But this won't help compatibility at all.

I'm thinking we just skip this and break compatibility. The visible scope is pretty new anyways.

  • Status changed from Open to Needs more information

Updated by Felix Schäfer at 2011-05-29 03:30 pm

Eric Davis wrote:

I'm thinking we just skip this and break compatibility. The visible scope is pretty new anyways.

I haven't seen it used anywhere, so I'd say drop it.

Updated by Eric Davis at 2011-05-29 06:27 pm

Removed the tests in bc24987

  • Assignee set to Eric Davis
  • Status changed from Needs more information to Closed

Also available in: Atom PDF