ChiliProject is not maintained anymore. Please be advised that there will be no more updates.
We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.
Liquid integration breaks on 1.9.2 (Bug #734)
| Status: | Closed | Start date: | 2011-11-26 |
|---|---|---|---|
| Priority: | Normal | Due date: | |
| Assignee: |  Holger Just |
% Done: | 0% |
| Category: | - | ||
| Target version: | 3.0.0 | ||
| Remote issue URL: | Affected version: | unstable |
Description
There's a problem on 1.9.2 with the liquid integration, as far as I could see it had something to do with gsub! on a frozen string and sub on a symbol http://ci.chiliproject.org/job/chiliproject_unstable/DATABASE=mysql2,RUBY=ruby-1.9.2-p290/lastCompletedBuild/testReport/
Holger, could you have a look?
Associated revisions
- to delete the hours
- to assign the hours to the project
- to reassign the hours to another issue
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1182 e93f8b46-1217-0410-a6f0-8f06a7374b81
[#734] Force instance_variables to string for Ruby 1.9 compatibility
[#734] Don't modify text inline.
This is not only a wee bit faster (yay!) but also allows use to deal with
frozen strings and doesn't change content which might inadvertently be saved
later on. And it fixes some broken tests on Ruby 1.9 :)
History
Updated by Holger Just at 2011-11-26 02:30 pm
Meh.
The reason for most of the errors is almost the same as in #711, i.e. that instance_variables in 1.8 returns an array of strings while it is an array of symbols in 1.9. I'm still investigating the rest of the errors.
Updated by Holger Just at 2011-11-26 04:25 pm
Fixed in 28ce07b1 and 9f4d12ff.
There is still one test failing, but that one doesn't belong to liquid. See http://ci.chiliproject.org/job/chiliproject_unstable/70/DATABASE=mysql2,RUBY=ruby-1.9.2-p290/ Unfortunately, I don't really know the cause.
- Status changed from Open to Closed