quotes around path when shelling out does not work on Windows (Bug #891)

FYI, by simply removing the quotes in version.rb I was able to confirm all tests pass on Windows Server 2003 SE SP2 with pg 0.9.0 and 0.13.1.

712 tests, 2199 assertions, 0 failures, 0 errors
...
1181 tests, 2141 assertions, 0 failures, 0 errors

Just removing the quotes probably won't be enough because it will probably break as soon as there's a space in the path, but it's a good starting point. I don't know windows enough, could you see if it works if double instead of single quotes?

You're probably right. I've done the tests again, even renamed my CP installation directory to contain a few spaces ("d:\sources\OSS\IT\dir with spaces\chiliproject"), with double quotes and all passed.
I've also run the tests on CentOS with this change to confirm it didn't break anything there.

This is what I now have in version.rb:

git.send(:shellout, "#{git.sq_bin} --git-dir=\"#{git_dir}\" rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp

I'd push a patch but git is giving me weird errors.

I promise I'll actually start writing my own fixes soon...haha. Here's another patch, it's working perfectly for me on a couple of RedHat 5/6 boxes:

diff --git a/lib/chili_project/version.rb b/lib/chili_project/version.rb
index 8065451..894e807 100644
--- a/lib/chili_project/version.rb
+++ b/lib/chili_project/version.rb
@@ -43,7 +43,7 @@ module ChiliProject
         git_dir = Rails.root.join('.git')

         if File.directory? git_dir
-          git.send(:shellout, "#{git.sq_bin} --git-dir='#{git_dir}' rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp
+          git.send(:shellout, "#{git.sq_bin} --git-dir=\"#{git_dir}\" rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp
         end
       end
     end

Toshi MARUYAMA wrote:

This commit cannot work on Linux path with double-quote.

Indeed, but it wouldn't have worked with a single-quote in the path before that either :-)

Thanks for noticing and reporting, I'll see about that before the next release.

Perhaps something like this instead?

diff --git a/lib/chili_project/version.rb b/lib/chili_project/version.rb
index 8065451..894e807 100644
--- a/lib/chili_project/version.rb
+++ b/lib/chili_project/version.rb
@@ -43,7 +43,7 @@ module ChiliProject
         git_dir = Rails.root.join('.git')

         if File.directory? git_dir
-          git.send(:shellout, "#{git.sq_bin} --git-dir='#{git_dir}' rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp
+          git.send(:shellout, "#{git.sq_bin} --git-dir=\"#{git_dir.gsub(/["]/, "\\\\\"")}\" rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp
         end
       end
     end

OK, this works on OS X with " and ' in the path, Dies (or anyone else), could you try this patch (against current master) on windows?

 1diff --git a/lib/chili_project/version.rb b/lib/chili_project/version.rb
 2index 894e807..2afb5a4 100644
 3--- a/lib/chili_project/version.rb
 4+++ b/lib/chili_project/version.rb
 5@@ -43,7 +43,7 @@ module ChiliProject
 6         git_dir = Rails.root.join('.git')
 7
 8         if File.directory? git_dir
 9-          git.send(:shellout, "#{git.sq_bin} --git-dir=\"#{git_dir}\" rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp
10+          git.send(:shellout, "#{git.sq_bin} --git-dir=#{git.shell_quote git_dir.to_s} rev-parse --short=9 HEAD") { |io| io.read }.to_s.chomp
11         end
12       end
13     end

I have applied the patch to today's master and reran the tests on Windows 7 in a directory name with spaces. All tests passed.