ChiliProject is not maintained anymore. Please be advised that there will be no more updates.

We do not recommend that you setup new ChiliProject instances and we urge all existing users to migrate their data to a maintained system, e.g. Redmine. We will provide a migration script later. In the meantime, you can use the instructions by Christian Daehn.

Change public strings of Redmine to ChiliProject (Feature #129)


Added by Eric Davis at 2011-02-03 01:22 am. Updated at 2011-02-21 11:47 pm.


Status:Closed Start date:2011-02-03
Priority:Normal Due date:
Assignee:Eric Davis % Done:

0%

Category:User interface
Target version:1.1.0 — Bell
Remote issue URL: Affected version:

footer-project-name.patch (1.3 kB) Matthew Connerton, 2011-02-05 04:00 am


Related issues

related to Task #128: Decide on ChiliProject copyright Closed 2011-02-03

Associated revisions

Revision 99a12ecb
Added by Eric Davis at 2011-02-20 05:38 am

[#129] Replace public strings using Redmine with ChiliProject

Revision 4dffc45e
Added by Eric Davis at 2011-02-22 12:36 am

[#129] Fix case on some ChiliProject strings

Revision 2d04d5e2
Added by Eric Davis at 2011-02-22 12:38 am

[#129] Remove the Copyright in the footer

Revision fb89e7a8
Added by Eric Davis at 2011-02-22 12:43 am

[#129] i18n the 'Powered by' string in the footer

Revision 1322fbba
Added by Eric Davis at 2011-11-25 08:28 pm

Merge pull request #129 from jwalkerbg/master

Added Bulgarian translation of several strings

History

Updated by Derek Montgomery at 2011-02-03 12:05 pm

Same goes for the 'Settings/Information' bit that says Redmine 1.0.4 so far

Updated by Matthew Connerton at 2011-02-05 04:00 am

This patch replaces "Redmine" with "ChiliProject" and removes the copywrite.

I propose its best to put something like this up sooner than later while we wait on the copywrite decisions (#128) to be made

  • File footer-project-name.patch added

Updated by Matthew Connerton at 2011-02-05 04:07 am

  • Status changed from Open to Ready for review

Updated by Eric Davis at 2011-02-10 11:56 pm

I'm going to do some reading up on US copyright law but I'll merge this until #128 is decided.

  • Assignee set to Eric Davis

Updated by Felix Schäfer at 2011-02-11 03:45 pm

There's a few more places I'd suggest changing:

  • app/models/mailer.rb (Redmine test, X-Redmine-*, X-Mailer
  • app/views/mailer/test* (sent by)
  • config/settings.yml (default settings)
  • db/migrate/001_setup.rb (name of the admin user)

That's the diff for me, minus the migration because for some weird reason (line endings?) git thinks I've changed 9/10 of the file:

 1diff --git a/app/models/mailer.rb b/app/models/mailer.rb
 2index 56f60e0..bbb0ac0 100644
 3--- a/app/models/mailer.rb
 4+++ b/app/models/mailer.rb
 5@@ -281,7 +281,7 @@ class Mailer < ActionMailer::Base
 6     redmine_headers 'Type' => "Test" 
 7     set_language_if_valid(user.language)
 8     recipients user.mail
 9-    subject 'Redmine test'
10+    subject 'ChiliProject test'
11     body :url => url_for(:controller => 'welcome')
12     render_multipart('test', body)
13   end
14@@ -362,16 +362,16 @@ class Mailer < ActionMailer::Base
15     from Setting.mail_from
16
17     # Common headers
18-    headers 'X-Mailer' => 'Redmine',
19-            'X-Redmine-Host' => Setting.host_name,
20-            'X-Redmine-Site' => Setting.app_title,
21+    headers 'X-Mailer' => 'ChiliProject',
22+            'X-ChiliProject-Host' => Setting.host_name,
23+            'X-ChiliProject-Site' => Setting.app_title,
24             'Precedence' => 'bulk',
25             'Auto-Submitted' => 'auto-generated'
26   end
27
28-  # Appends a Redmine header field (name is prepended with 'X-Redmine-')
29+  # Appends a ChiliProject header field (name is prepended with 'X-ChiliProject-')
30   def redmine_headers(h)
31-    h.each { |k,v| headers["X-Redmine-#{k}"] = v }
32+    h.each { |k,v| headers["X-ChiliProject-#{k}"] = v }
33   end
34
35   # Overrides the create_mail method
36diff --git a/app/views/mailer/test.text.html.rhtml b/app/views/mailer/test.text.html.rhtml
37index 25ad20c..96946bc 100644
38--- a/app/views/mailer/test.text.html.rhtml
39+++ b/app/views/mailer/test.text.html.rhtml
40@@ -1,2 +1,2 @@
41-<p>This is a test email sent by Redmine.<br />
42-Redmine URL: <%= auto_link(@url) %></p>
43+<p>This is a test email sent by ChiliProject.<br />
44+ChiliProject URL: <%= auto_link(@url) %></p>
45diff --git a/app/views/mailer/test.text.plain.rhtml b/app/views/mailer/test.text.plain.rhtml
46index 790d6ab..257ec14 100644
47--- a/app/views/mailer/test.text.plain.rhtml
48+++ b/app/views/mailer/test.text.plain.rhtml
49@@ -1,2 +1,2 @@
50-This is a test email sent by Redmine.
51-Redmine URL: <%= @url %>
52+This is a test email sent by ChiliProject.
53+ChiliProject URL: <%= @url %>
54diff --git a/config/settings.yml b/config/settings.yml
55index 6a9676a..5b8a7b4 100644
56--- a/config/settings.yml
57+++ b/config/settings.yml
58@@ -20,7 +20,7 @@
59 # Settings can be defined through the application in Admin -> Settings
60
61 app_title:
62-  default: Redmine
63+  default: ChiliProject
64 app_subtitle:
65   default: Project management
66 welcome_text:
67@@ -46,7 +46,7 @@ activity_days_default:
68 per_page_options:
69   default: '25,50,100'
70 mail_from:
71-  default: redmine@example.net
72+  default: chiliproject@example.net
73 bcc_recipients:
74   default: 1
75 plain_text_mail:

Updated by Eric Davis at 2011-02-11 07:30 pm

Felix:

I have some of this code in SeeProjectRun I can extract. I think we should just focus on the public strings for now and change the internal ones later (class and module names)

  • Subject changed from Change the footer in the layout to say ChiliProject to Change public strings of Redmine to ChiliProject

Updated by Felix Schäfer at 2011-02-11 09:26 pm

Eric Davis wrote:

I have some of this code in SeeProjectRun I can extract. I think we should just focus on the public strings for now and change the internal ones later (class and module names)

All the ones I referenced but the mail headers are public-facing at one point or another ;-)

Updated by Eric Davis at 2011-02-20 04:42 am

I found a bunch more public strings including some headers (mail, web, api). Can someone review my pull request to make sure I didn't miss anything or break anything?

https://github.com/chiliproject/chiliproject/pull/12

Updated by Felix Schäfer at 2011-02-20 05:46 pm

Eric Davis wrote:

I found a bunch more public strings including some headers (mail, web, api).

Well, I had considered the "viewable" strings only, but those are OK too.

Can someone review my pull request to make sure I didn't miss anything or break anything?

I had a look and didn't see anything strange or that I'd consider breaking, though you should probably correct the 2 "Chiliproject"s in that file https://github.com/chiliproject/chiliproject/pull/12/files#L14L0 to "ChiliProject" :-) I haven't searched if you've overlooked things either, but you have my go for that one, commit at will.

Updated by Felix Schäfer at 2011-02-20 05:47 pm

Ah, one more thing though: I'd be in favor of dropping the copyright notice in the footer completely, I think it's enough if it says "Powered by ChiliProject".

Updated by Muntek Singh at 2011-02-20 06:06 pm

Felix Schäfer wrote:

Ah, one more thing though: I'd be in favor of dropping the copyright notice in the footer completely, I think it's enough if it says "Powered by ChiliProject".

This is probably what we want to do until we get the copyright/legal stuff properly figured out anyways.

Updated by Eric Davis at 2011-02-21 11:47 pm

Thanks. The test fixtures and footer have been updated and merged into master. I also i18n'd the "Powered by" string in fb89e7a842f162e5b1086a0a06a071069d9dc36a.

  • Status changed from Ready for review to Closed

Also available in: Atom PDF